Fix PHPStan rule level 0 errors in php-ai-client#10990
Fix PHPStan rule level 0 errors in php-ai-client#10990westonruter wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Co-authored-by: gemini-cli <218195315+gemini-cli@users.noreply.github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
JasonTheAdams
left a comment
JasonTheAdams
left a comment
There was a problem hiding this comment.
Happy to bring this into compatibility with PHPStan! Thanks!
Developed in #10990 Follow-up to r61699, r61700. Props westonruter, SirLouen, jason_the_adams. See #64591, #61175. git-svn-id: https://develop.svn.wordpress.org/trunk@61712 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress/wordpress-develop#10990 Follow-up to r61699, r61700. Props westonruter, SirLouen, jason_the_adams. See #64591, #61175. Built from https://develop.svn.wordpress.org/trunk@61712 git-svn-id: http://core.svn.wordpress.org/trunk@61020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
| - ../../src/wp-includes/SimplePie | ||
| - ../../src/wp-includes/sodium_compat | ||
| - ../../src/wp-includes/Text | ||
| - ../../src/wp-includes/php-ai-client/third-party |
There was a problem hiding this comment.
@westonruter @felixarntz should the entire php-ai-client directory be ignored by PHPStan?
I think from the perspective of wordpress-core the entire php-ai-client is external, and while I'm not sure if syncs like #11102 are manual or automatic, I'd assume we don't want to keep clobbering them back into the codebase
There was a problem hiding this comment.
I'm opening one. There are currently 2,489 errors errors in trunk 😬
There was a problem hiding this comment.
Or no, sorry, that was my stale cache apparently.
3 participants
There are 81 errors being reported by PHPStan in the
wp-includes/php-ai-clientdirectory, most of which are in thethird-partysubdirectory.This is a follow-up to r61699/8a82e67 from Core-61175 and r61700/52e3c30 from Core-64591.
Output of
composer phpstanTrac ticket: https://core.trac.wordpress.org/ticket/64591
Use of AI Tools
Gemini CLI fixed the issues.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.